168cffea8b
Both student-facing surfaces (the per-device join page and the
front-of-room projector) now render options as text only, no A/B/C/D
chips, no numeric prefixes. The letter-namespace remains internal:
canonical A..D in pool.json + submissions storage; canonical position
1..4 in the CSV export. Admin dashboard keeps letters because it is the
instructor's private console.
Why this lands now: the discussion of per-student option shuffling
flagged that A/B/C/D as discussion handles ("the answer is B") is itself
a leaky channel. Removing the labels closes that channel for the
non-shuffled case and keeps it closed if shuffling is added later.
Wire protocol: the submit message carries the option's full text
("answer": "Pipelining"). Server's submit_answer resolves text -> letter
via app.pool.resolve_option_key, which also accepts a canonical letter
so internal callers and tests stay readable. A non-matching string is
recorded as a zero-score submission with answer=NULL, locked in via the
PK + existing_submit_ack short-circuit. So an attempted UI bypass that
posts a fabricated string just produces a wrong answer; no retry.
CSV: A=1 .. D=2 .. C=3 .. D=4 in the answer column. Empty when no option
matched. Header unchanged so downstream pandas readers don't break, but
the value type is int instead of letter.
Histogram: the failsafe "submitted-but-no-match" row buckets into
"missed" alongside genuine misses — both yield zero credit and the
instructor cares about the same thing.
Tests:
- test_submit_accepts_option_text_resolves_to_canonical: production
wire format produces correct grading + canonical-letter storage.
- test_submit_failsafe_locks_in_zero_score_on_garbage_text: a non-
matching string is recorded at score=0 and a follow-up correct
submission cannot overwrite it.
71/71 green.
25 lines
1.1 KiB
Python
25 lines
1.1 KiB
Python
from conftest import admin_login, join_student
|
|
|
|
|
|
def test_csv_export_contains_one_row_per_submission(client, sid):
|
|
admin_login(client)
|
|
join_student(client, sid, "s1", "Student One")
|
|
rooms = client.app.state.rooms
|
|
client.portal.call(rooms.open_question, sid, 0, 2)
|
|
ack = client.portal.call(rooms.submit_answer, sid, "s1", 0, "B")
|
|
assert ack["type"] == "submit_ack"
|
|
client.portal.call(rooms.close_question, sid)
|
|
|
|
response = client.get("/admin/api/csv")
|
|
lines = response.text.strip().splitlines()
|
|
assert lines[0] == "sid,student_id,name,question_idx,answer,elapsed_ms,score,status,blur_count,hidden_count,duplicate_join_attempts"
|
|
assert len(lines) == 2
|
|
# The CSV stores the canonical 1-indexed position of the chosen
|
|
# option (A=1, B=2, C=3, D=4) rather than the letter — the student
|
|
# UI is letterless and a number is unambiguous for downstream
|
|
# analysis.
|
|
assert ",s1,Student One,0,2," in lines[1]
|
|
# Default audit-event counts are 0 for a clean run (no blur events,
|
|
# no duplicate-join attempts).
|
|
assert lines[1].endswith(",0,0,0")
|